Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import LXD changes #191

Merged
merged 14 commits into from
Oct 24, 2023
Merged

Import LXD changes #191

merged 14 commits into from
Oct 24, 2023

Conversation

stgraber
Copy link
Member

No description provided.

mihalicyn and others added 11 commits October 23, 2023 21:46
Network interface name must be double-quoted to avoid
collisions with the nftables syntax.

For example a bridge network called `rt` will cause the following error prior to this commit:
```
Error: syntax error, unexpected rt
           iifname rt jump acl.rt
                   ^^
```
when trying to set ACL:
`incus network set rt security.acls="rt-acl"`
because `rt` is a restricted token in the nftables syntax:
https://wiki.nftables.org/wiki-nftables/index.php/Quick_reference-nftables_in_10_minutes#Rt

Signed-off-by: Rafal Borczuch <[email protected]>
@github-actions github-actions bot added the Documentation Documentation needs updating label Oct 24, 2023
ru-fu and others added 2 commits October 23, 2023 22:47
You can specify an initial volume configuration for the root disk
device when creating an instance. We have documentation for that,
but it's hard to find. Therefore, add a link to it from the instance
creation howto.

Signed-off-by: Ruth Fuchss <[email protected]>
…` for cgroups

Cgroup storage limits are not applied when the container starts up. That
is because `IsRunning` returns `false` during the container startup.

This commits fixes this issue by relying on `InitPID` instead of
`IsRunning`. The former will return a positive integer if the container
is running even if the container is not fully set up yet.

Fixes #12343

Signed-off-by: Thomas Hipp <[email protected]>
@brauner brauner merged commit 74f56e7 into lxc:main Oct 24, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

8 participants